[Neo-report] r2438 vincent - /trunk/neo/tests/storage/testReplicationHandler.py

nobody at svn.erp5.org nobody at svn.erp5.org
Tue Nov 9 14:16:42 CET 2010


Author: vincent
Date: Tue Nov  9 14:16:41 2010
New Revision: 2438

Log:
Use sets, as order actually doesn't matter.

Modified:
    trunk/neo/tests/storage/testReplicationHandler.py

Modified: trunk/neo/tests/storage/testReplicationHandler.py
==============================================================================
--- trunk/neo/tests/storage/testReplicationHandler.py [iso-8859-1] (original)
+++ trunk/neo/tests/storage/testReplicationHandler.py [iso-8859-1] Tue Nov  9 14:16:41 2010
@@ -151,11 +151,12 @@ class StorageReplicationHandlerTests(Neo
         self.assertEqual(len(calls), 1)
         calls[0].checkArgs(pmin_oid, pmin_serial, plength, ppartition)
 
-        self.assertEqual(len(packet_list), len(object_list), packet_list)
-        for packet, (oid, serial) in zip(packet_list, object_list):
-            self.assertEqual(packet.getType(),
-                Packets.AskObject)
-            self.assertEqual(packet.decode(), (oid, serial, None))
+        self.assertEqual(len(packet_list), len(object_list),
+            ([x.decode() for x in packet_list], object_list))
+        reference_set = set((x + (None, ) for x in object_list))
+        packet_set = set((x.decode() for x in packet_list))
+        assert len(packet_list) == len(reference_set) == len(packet_set)
+        self.assertEqual(reference_set, packet_set)
 
     def test_connectionLost(self):
         app = self.getApp()





More information about the Neo-report mailing list